Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CvCodeSnippetSkeleton component #226

Merged
merged 2 commits into from
Feb 27, 2019
Merged

feat: add CvCodeSnippetSkeleton component #226

merged 2 commits into from
Feb 27, 2019

Conversation

ConradSchmidt
Copy link
Contributor

Issue #167

Adds CvCodeSnippetSkeleton components. Updates CvCodeSnippet story.

Changelog

New

  • CvCodeSnippetSkeleton

Changed

  • CvCodeSnippet story

@ConradSchmidt ConradSchmidt changed the title feat: add CvCodeSnippedSkeleton component feat: add CvCodeSnippetSkeleton component Feb 27, 2019
lee-chase
lee-chase requested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tended to use kind instead of type, due to type being a standard property in some html elements.

This would be consistent with the code snippet component.

@ConradSchmidt
Copy link
Contributor Author

I changed the kind analog to the main component

@ConradSchmidt ConradSchmidt reopened this Feb 27, 2019
@lee-chase lee-chase merged commit f032557 into carbon-design-system:master Feb 27, 2019
dcwarwick pushed a commit to dcwarwick/carbon-components-vue that referenced this pull request Mar 18, 2019
@ConradSchmidt @dcwarwick
feat: add CvCodeSnippetSkeleton component (carbon-design-system#226)
8631bcb
dcwarwick pushed a commit to dcwarwick/carbon-components-vue that referenced this pull request Mar 18, 2019
@ConradSchmidt @dcwarwick
feat: add CvCodeSnippetSkeleton component (carbon-design-system#226)
f54ddbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee-chase lee-chase lee-chase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConradSchmidt @lee-chase