Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CvFileUploadSkeleton component #228

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

ConradSchmidt
Copy link
Contributor

Issue #167

Adds CvFileUploadSkeleton components. Updates CvFileUpload story.

Changelog

New

  • CvFileUploadSkeleton

Changed

  • CvFileUpload story

Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn lint:es fails TextSkeleton and ButtonSkeleton must match usage or be of the form CvSkeletonText and CvButtonSkeleton

@ConradSchmidt
Copy link
Contributor Author

Maybe the "yarn es:lint"/"npm run es:lint" task should be added as step to the contribution page?

@lee-chase lee-chase merged commit 63c6e63 into carbon-design-system:master Feb 28, 2019
dcwarwick pushed a commit to dcwarwick/carbon-components-vue that referenced this pull request Mar 18, 2019
* feat: add CvFileUploadSkeleton component

* feat: fix linting errors
dcwarwick pushed a commit to dcwarwick/carbon-components-vue that referenced this pull request Mar 18, 2019
* feat: add CvFileUploadSkeleton component

* feat: fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants