Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skeleton for cv search component #629

Conversation

Pablodotnet
Copy link

@Pablodotnet Pablodotnet commented Oct 24, 2019

Add skeleton to CvSearch component #167

Changelog

A packages/core/src/components/cv-search/cv-search-skeleton.vue
M packages/core/src/components/cv-search/index.js
M packages/core/src/index.js
M storybook/stories/cv-search-story.js

Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search skeleton is not of the correct form and needs to be switchable between xl and sm. The for and id attributes are not needed.

e.g.

<div class="{{@root.prefix}}--form-item">
  <div role="search" class="{{@root.prefix}}--search {{@root.prefix}}--skeleton {{@root.prefix}}--search--xl ">
    <label for="search-skel" class="{{@root.prefix}}--label"></label>
    <div id="search-skel" type="text" role="search" class="{{@root.prefix}}--search-input"></div>
  </div>
</div>

<div class="{{@root.prefix}}--form-item">
  <div role="search" class="{{@root.prefix}}--search {{@root.prefix}}--skeleton {{@root.prefix}}--search--sm ">
    <label for="search-skel-sm" class="{{@root.prefix}}--label"></label>
    <div id="search-skel-sm" type="text" role="search" class="{{@root.prefix}}--search-input"></div>
  </div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants