Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Selectable Components: Tile & Structured List] Figma Kit #744

Closed
17 tasks done
Tracked by #14722
Kritvi-bhatia opened this issue Jan 2, 2024 · 7 comments
Closed
17 tasks done
Tracked by #14722

[Selectable Components: Tile & Structured List] Figma Kit #744

Kritvi-bhatia opened this issue Jan 2, 2024 · 7 comments

Comments

@Kritvi-bhatia
Copy link

Kritvi-bhatia commented Jan 2, 2024

Acceptance criteria

Update the All themes Figma kit with any changes that came out of the final design specs for selectable components.

  • Consult @juanencalada about the build of current Figma components and with any outstanding questions.

Tiles

  • Update the radio button icon in tiles
  • Update the inconsistencies, bugs, miss
    • Add the disabled state for enabled state in both single & multi-select
    • Update all the Titles' and Descriptions' fonts as "body-compact-1"
    • Link all the text styles
    • For the disabled states, fix the border color as $border-disabled

Structured list

  • Update the icon in the structured list (from checkmark to radio button)
  • Add the state where the icon will be on the left
  • Along with the transparent structured list, add the whole set of structured list with background too
  • Remove the flush state from the non-selectable structured list
  • Update all the inconsistencies, bugs, miss
    • Headers' height inconsistencies
    • Add all the different states (selected, enabled, hover, focus, disabled)
    • Link all the text styles

Review

  • Review (carbon designer)
  • Review (figma expert/Juan)
@laurenmrice laurenmrice changed the title Update Figma components Selectable components: update Figma kit Jan 3, 2024
@laurenmrice laurenmrice changed the title Selectable components: update Figma kit Selectable Components: Update Figma Kit Jan 3, 2024
@laurenmrice laurenmrice transferred this issue from carbon-design-system/carbon Jan 3, 2024
@laurenmrice laurenmrice added this to the 2024 Q1 milestone Jan 3, 2024
@Kritvi-bhatia Kritvi-bhatia changed the title Selectable Components: Update Figma Kit Update Figma Kit : Selectable Components Jan 11, 2024
@Kritvi-bhatia Kritvi-bhatia changed the title Update Figma Kit : Selectable Components [Figma] Update Figma Kit : Selectable Components Jan 12, 2024
@Kritvi-bhatia Kritvi-bhatia changed the title [Figma] Update Figma Kit : Selectable Components [Figma] Update Tiles & Structured List : Selectable Components Jan 12, 2024
@laurenmrice laurenmrice added the version: 11 Issues pertaining to Carbon v11 label Jan 29, 2024
@juanencalada
Copy link
Collaborator

Hey @Kritvi-bhatia,

  1. I updated the order and placement of some of the accessible borders
  2. I would reset defaults on the icons so that the vector layer remains locked as is intended from the icon library:
    image
  3. I would lock this frame and also consider setting up icon swap properties for them and include preferred values based on what IBM Dotcom is doing. I would ask @laurenmrice for her thoughts on this to see if she also feels this is something we'd like to offer to users as a nice to have. At the very least I'd lock the layers to reduce selectability distraction
image image image
  1. There are conflicting variants from having the same properties. I would consider removing the bottom half:
    image

@juanencalada
Copy link
Collaborator

For Structured list:

  1. I renamed the second one to Structured list - Selectable
image

@juanencalada
Copy link
Collaborator

juanencalada commented Jan 31, 2024

Depending on why we need the background, we might be able to move the background layer out of the rows, and directly into the whole table as a boolean property that's available only for the hang variants. This would get rid of 2 variants for each of the components
image

@Kritvi-bhatia
Copy link
Author

Kritvi-bhatia commented Jan 31, 2024

Hi @juanencalada!!
(in reply to your first comment)

  1. Thanks for doing that
  2. I've done that, thanks for pointing out
  3. So I've locked the icon layer but regarding adding the icon swap and all will consider in the next update / issue as currently I'm just focusing only on the selectable components. So regarding the icon swap thing that you were mentioning, did you mean something like this - (example of data table)
image
  1. Not sure, nothing is conflicting for me though 🤔
image

@Kritvi-bhatia
Copy link
Author

(In reply to your third comment)
I've updated it now as you recommended, can you please check now!?

@juanencalada
Copy link
Collaborator

Hey @Kritvi-bhatia
What is the background layer for exactly? Is layer-selected-hover-01 the correct token?
image

@Kritvi-bhatia17
Copy link

Heyy @juanencalada
In reply to the above comment, I've updated it!

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Figma] Update Tiles & Structured List : Selectable Components [Selectable Components: Tiles & Structured List] Update Figma Kit Feb 14, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Selectable Components: Tiles & Structured List] Update Figma Kit [Selectable Components / Tiles & Structured List] Update Figma Kit Feb 14, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Selectable Components / Tiles & Structured List] Update Figma Kit [Selectable Components > Tiles & Structured List] Update Figma Kit Feb 14, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Selectable Components > Tiles & Structured List] Update Figma Kit [Selectable Components: Tiles & Structured List] Update Figma Kit Feb 14, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Selectable Components: Tiles & Structured List] Update Figma Kit [Selectable Components: Tile & Structured List] Update Figma Kit Feb 14, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Selectable Components: Tile & Structured List] Update Figma Kit [Selectable Components: Tile & Structured List] Figma Kit Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants