Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with StructuredList code example tab index #3641

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Fix issues with StructuredList code example tab index #3641

merged 3 commits into from
Jul 17, 2023

Conversation

tw15egan
Copy link
Member

Closes #3632

Fixes some issues with the StructuredList code examples

Changelog

Changed

  • Copied the code from the storybook selection example for StructuredList

@tw15egan tw15egan requested review from a team as code owners July 12, 2023 17:19
@vercel
Copy link

vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 4:41pm

@tw15egan tw15egan changed the title Structured list tab index Fix issues with StructuredList code example tab index Jul 12, 2023
laurenmrice
laurenmrice approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@kodiakhq kodiakhq bot merged commit 282ad87 into carbon-design-system:main Jul 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structured list Live demo does not match storybook
4 participants
@tw15egan @alisonjoseph @tay1orjones @laurenmrice