Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken storybook example url's in UI-Shell, CheckBox #4292

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix broken storybook example url's in UI-Shell, CheckBox #4292

merged 2 commits into from
Sep 27, 2024

Conversation

2nikhiltom
Copy link
Contributor

Closes #4291

This PR fixes react storybook broken URLs

Changelog

URL's updated

Review

Open deploy preview
Verify react storybook pages open for all variants of UIShell and CheckBox components

@2nikhiltom 2nikhiltom requested review from a team as code owners September 26, 2024 14:14
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:58pm

tay1orjones
tay1orjones approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Kritvi-bhatia17
Kritvi-bhatia17 reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nikhil! Thanks for fixing the broken links.

I just had a quick question—was there a reason behind not adding the respective component’s React overview page link? For example, for the checkbox, the updated link could be this: Checkbox React overview.

@2nikhiltom
Copy link
Contributor Author

Kritiv,
I observed most of the component's react storybook examples are linked to there default variants

Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed most of the component's react storybook examples are linked to there default variants

Got it, Nikhil! Thanks for confirming. LGTM 🚀

As a side note, I’ve noticed there are a few more components where the React link in the Code tab is broken. I’m not sure if it’s due to a recent change or something else. I’ll create a separate issue for it for now.

@2nikhiltom 2nikhiltom merged commit bede45c into carbon-design-system:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@benjamin-kurien benjamin-kurien Awaiting requested review from benjamin-kurien benjamin-kurien is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React storybook example url's are broken for UI-Shell & CheckBox components
4 participants
@2nikhiltom @tay1orjones @ariellalgilmore @Kritvi-bhatia17