Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Status indicator] Update Status indicator pattern guidance #4309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Oct 3, 2024

Closes ##4272 and #4050


Figma file review: https://www.figma.com/design/EqKmxlJmBiEB4yPBKpGlrZ/Status-Indicator-(Pattern)?node-id=1-1365

New

  • Variant table
  • Icon vs Shape indicator

Changelog

  • Structure in general
  • Icon indicator table in its variant
  • Removed a few icon indicators in the table
  • Removed one shape indicator in the table
  • Other general guidance on labeling, type pairing, and accessibility

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:13pm

@alisonjoseph
Copy link
Member

The not started light image isn't displaying, I think the file might be missing.

Screenshot 2024-10-04 at 9 14 29 AM

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome work Thy! I left a few formatting suggestions here in the PR and also some other general comments and questions over in Figma.

src/pages/patterns/status-indicator-pattern/index.mdx Outdated Show resolved Hide resolved
src/pages/patterns/status-indicator-pattern/index.mdx Outdated Show resolved Hide resolved
src/pages/patterns/status-indicator-pattern/index.mdx Outdated Show resolved Hide resolved
src/pages/patterns/status-indicator-pattern/index.mdx Outdated Show resolved Hide resolved
src/pages/patterns/status-indicator-pattern/index.mdx Outdated Show resolved Hide resolved
There are at least four possible ways to implement status indicators:
Status indicators have been paired with specific type sizes that work best in
products. While shape indicators can be paired with a larger size, it’s
recommended to use 14pt or 12pt in smaller spaces or when used as a secondary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be px instead of pt?

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM other than one comment around using px instead of pt when referring to font sizes.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things still

@@ -509,8 +516,8 @@ our system.
#### Color

Differential indicators are either displaying a positive or a negative value.
Color is optional in these situations as long as the value has either a ‘+’ or
‘-’ in front of it, a chevron icon, or an arrow icon. Unless the data involves
Color is optional in these situations as long as the value has either a "+" or
Copy link
Member

@aagonzales aagonzales Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes here are coming in wrong here.
image


<StatusIndicatorTable attention="high" />
If your product needs an icon that’s not currently included, please reach out to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say open an issue instead here and link them to the correct repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say the same thing! Just so people know where to go if they need to contact us or to submit an icon

started, and purple indicates outliers or undefined statuses.
information and workflow progress. This status color palette also includes gray
and purple to add more depth to the system. Gray indicates drafts or jobs that
haven’t been started, and purple indicates outliers or undefined statuses.

<ColorPalette twoColumn type="status" />

#### Extended status palettes

This palette is only for added contrast accessibility when using yellows and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still say these colors are not part of the brand palette and should not be used in other contexts.

@thyhmdo
Copy link
Member Author

thyhmdo commented Oct 17, 2024

Alina's feedback:

An image will help improve this context

image


Taylor's feedback

  • Adding a fill behind some icons would work (like how other Warning and Failed states are being implemented right now)
.#{$prefix}--text-input__invalid-icon--warning {
    fill: $support-warning;
  }

Slight difference there is for the inputs we always set background-color: $field; whereas with standalone status icons we won't know/control what background they're placed on.
We could scope the selectors to set specific fill on each layer though, in addition to the $background

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, @thyhmdo ! Just a couple of minor things. Great work! ⭐️

  • The square border around the icons/symbols should be Magenta 60 to match the line that connects to it.
Screenshot 2024-10-18 at 8 35 33 AM
  • This image under the Shape indicator section needs to be updated to show the correct colors for the indicators in the data table. Right now they all look orange.
Screenshot 2024-10-18 at 8 55 44 AM
  • I think this column header for this section should say "Shape" instead of "Icon"?
Screenshot 2024-10-18 at 8 57 56 AM
  • I noticed that in the Shape indicator table you use slashes to separate different tokens per shape, but in the Icon indicator table you use commas. I would just pick one approach for consistency, maybe just use the comma?


| Variant | Usage | Use cases |
| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- |
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets |
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color, and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets |

| Variant | Usage | Use cases |
| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- |
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets |
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams |
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amounts of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just double check the use of periods in the Usage and Use cases columns for all of the descriptions. There should be periods after complete sentences.

| ---------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- |
| [Icon indicator](#icon-indicator) | Used any time the layout offers ample space and the content requires maximum attention. They require an icon, a shape, a meaningful color and a descriptive inline label. | Most often used in notifications, progress indicators, data tables, task lists, and dashboard widgets |
| [Shape indicator](#shape-indicator) | Useful in smaller spaces or when users need to scan large amount of data. | Most often used in lists, dashboards, data tables, data visualizations, and network diagrams |
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header, and used in conjunction with avatars or icons |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header, and used in conjunction with avatars or icons |
| [Badge indicator (with number)](#badge-indicator) | Useful when a count of new or updated items is available, and it is important for the user to know the number of updates. | Most often used in notification panes in the header and used in conjunction with avatars or icons |


<StatusIndicatorTable attention="high" />
If your product needs an icon that’s not currently included, please reach out to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say the same thing! Just so people know where to go if they need to contact us or to submit an icon

Icons are visual symbols that represent ideas, objects, or actions. They help
communicate messages quickly, encourage interactivity, and highlight important
information—like exclamation points for warnings, checkmarks for success, and
question marks for help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
question marks for help
question marks for help.


![Four icons with badges that included numbers ranging from one to three digits. The last badge has a plus.](./images/status-badge-with-number.png)

<Caption>Badges with numbers range from one to three digits</Caption>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Caption>Badges with numbers range from one to three digits</Caption>
<Caption>Badges with numbers ranging from one to three digits</Caption>

to the user. This dot badge is more subtle than the numbered badge but still
effectively draws the user’s attention to the icon button.

The badge without number is commonly seen in toolbars' icon buttons.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The badge without number is commonly seen in toolbars' icon buttons.
The badge without a number is commonly seen in toolbars' icon buttons.

with color vision deficiencies (refer to
[Use of Color](https://www.w3.org/WAI/WCAG22/Understanding/use-of-color.html)).
While color can be useful, it must be paired with text or other visual cues. To
meet accessibility standards, and to pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meet accessibility standards, and to pass
meet accessibility standards and to pass


![Example of accessible status indicators](images/status_indicator_17.png)
Using symbols alone is acceptable, as long as they meet non-text contrast
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using symbols alone is acceptable, as long as they meet non-text contrast
Using symbols alone is acceptable as long as they meet non-text contrast


#### Users should be able to manage or limit non-critical notifications.
<Caption>
Example shows the icon indicators do not need outlines while icon indicators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example shows the icon indicators do not need outlines while icon indicators
Example shows the icon indicators do not need outlines, while icon indicators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging this pull request may close these issues.

4 participants