fix: a11y status for menu button #4313
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey there @alisonjoseph the issue for wrong menu button github link is that in storybook its "Menu button" but in carbon website its "Menu buttons" which is making incorrect github url. For now I fixed it with a hack because I was not sure renaming Menu buttons as "Menu button" as it can break other things too in carbon website !! what do you think ? |
| <A11yStatus layout="table" components="Menu buttons" /> | ||
| <A11yStatus | ||
| layout="table" | ||
| components={['Menu buttons', 'Combo button', 'Overflow menu']} |
There was a problem hiding this comment.
| components={['Menu buttons', 'Combo button', 'Overflow menu']} | |
| components={['Menu button', 'Combo button', 'Overflow menu']} |
There was a problem hiding this comment.
I already did that but there is no component called menu button so its not even getting rendered in the table thats what I was not sure about either I should rename to component in carbon website or I should do that CUSTOM LOGIC , as I think renaming the component might break many things in website.
There was a problem hiding this comment.
Ah I think I know what's missing. This needs to get added to the data/components.json for Menu Button to show up.
{
"component": "Menu button",
"parentComponent": "Menu buttons",
"overview": false,
"testing": {
"screenreader": "manual"
}
},
Closes #4241
Added Combo button and Overflow menu to a11y tab in menubuttons and fixed github link for menu button
Changelog
New
Added Combo button and Overflow menu to a11y tab in menubuttons and fixed github link for menu button