Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design kits] Update the the Figma file name #4326

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Oct 16, 2024

Closes #4297

Changelog

Changed

  • Change all the images with the new UI3

Removed

  • Removed any content that has "All themes". Except for the content in the notification.

@thyhmdo thyhmdo added this to the 2024 Q4 milestone Oct 16, 2024
@thyhmdo thyhmdo requested review from a team as code owners October 16, 2024 17:09
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Oct 24, 2024 8:18pm

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good to me!

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had one extra credit comment below

To preview the All themes library, visit the following view-only link. To access
the v10 Figma theme libraries, see
To preview the Carbon Design System library, visit the following view-only link.
To access the v10 Figma theme libraries, see
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't directly related but I think since we just reached end-of-support for v10 we can actually just remove this whole v10 sentence.

@alisonjoseph alisonjoseph merged commit 4d19e4e into carbon-design-system:main Oct 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Update design kit names
4 participants