Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .yarnrc leftover #14470

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

dbrugger
Copy link
Contributor

When looking into a solution for #14235, I saw carbon is on yarn v3 but still has a .yarnrc floating around. This file is now ignored according to https://yarnpkg.com/migration/guide#update-your-configuration-to-the-new-settings

Changelog

Removed

  • .yarnrc

Testing / Reviewing

  • test local development flow

@dbrugger dbrugger requested a review from a team as a code owner August 19, 2023 14:25
@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 7ecf515
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e4dca319f50c0008810a36
😎 Deploy Preview https://deploy-preview-14470--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7ecf515
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e4dca31bf71a00083371f6
😎 Deploy Preview https://deploy-preview-14470--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous understanding of this was that we still needed this file because Netlify only formally supported yarn v1/classic. By incrementing the version in the .yarnrc we were sort of tricking Netlify into allowing our deploy previews to build.

Looking into it again though, I see netlify/build-image#779 has now been resolved but there are still a couple outstanding issues as it relates to yarn berry/v3

The deploy previews did succeed on this PR, so that's a good sign.

@carbon-design-system/developers-system I think it's worth trying to merge this and if we have issues with Netlify deploy previews we may need additional config. Or we could roll back to put yarnrc back in.

@dbrugger
Copy link
Contributor Author

dbrugger commented Aug 22, 2023

i also find yarn versioning confusing. I recently updated one of our projects to v3, and it took a while for me to understand that yarn consists of two parts:

  • the yarn cli on the system, which always is v1
  • the yarn code in .yarn/releases which in this case is v3

on my system when I run yarn --version in the carbon repo, it shows 3.6.1. when I run it in ~, it shows 1.22.19.
Netlify will have the yarn cli, and use whatever is in .yarn/releases. I cannot imagine a true v1 being able to deal with that lock file format anyway.

@tw15egan tw15egan added this pull request to the merge queue Aug 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2023
@tw15egan tw15egan enabled auto-merge August 22, 2023 16:04
@tw15egan tw15egan added this pull request to the merge queue Aug 22, 2023
Merged via the queue into carbon-design-system:main with commit b89166e Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants