-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove .yarnrc leftover #14470
chore: remove .yarnrc leftover #14470
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous understanding of this was that we still needed this file because Netlify only formally supported yarn v1/classic. By incrementing the version in the .yarnrc
we were sort of tricking Netlify into allowing our deploy previews to build.
Looking into it again though, I see netlify/build-image#779 has now been resolved but there are still a couple outstanding issues as it relates to yarn berry/v3
- Yarn 3 workspaces are not cached at all netlify/build-image#615
- Fix support for Yarn Plug'n Play in the plugins execution netlify/build#1535
The deploy previews did succeed on this PR, so that's a good sign.
@carbon-design-system/developers-system I think it's worth trying to merge this and if we have issues with Netlify deploy previews we may need additional config. Or we could roll back to put yarnrc
back in.
i also find yarn versioning confusing. I recently updated one of our projects to v3, and it took a while for me to understand that yarn consists of two parts:
on my system when I run |
When looking into a solution for #14235, I saw carbon is on yarn v3 but still has a
.yarnrc
floating around. This file is now ignored according to https://yarnpkg.com/migration/guide#update-your-configuration-to-the-new-settingsChangelog
Removed
.yarnrc
Testing / Reviewing