fix(menu): update styles #15236
Merged
fix(menu): update styles #15236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
requested review from
a team,
laurenmrice and
thyhmdo
and removed request for
a team and
laurenmrice
|
@alisonjoseph this looks good! The only one thing is we still maintain the Here is the reference https://carbondesignsystem.com/components/menu/style#interactive-state-color |
|
@thyhmdo just updated the hover color to the primary tokens. Do you know what the max-height value should be? |
|
The only weird thing I see is here - seems the dropdown content doesn't stick to the menubutton - not sure if we care to address this or not 👀 @alisonjoseph Screen.Recording.2023-11-30.at.10.11.48.mov |
|
@andreancardona I see that too, unrelated to anything in this PR though |
andreancardona
approved these changes
Nov 30, 2023
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tay1orjones
approved these changes
Dec 4, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: visual review 🔍
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
* fix(menu): update spacing and add title to menuitem * fix(menu): add max-height and scroll to menu * fix: set hover color menu to primary * chore: remove max-height value and revert storybook changes * chore: storybook example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14676
Changelog
New
MenuItemMenuChanged
MenuButtonandComboButton$text-primaryto$text-secondary, and explicityly set svgs inside to$icon-secondary,Testing / Reviewing
Check Menu, MenuButton and ComboButton that they display correctly with updated tokens and that long text that overflows shows title on hover.
Review scrollbar on MenuButton default story