-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 15327-incorrect-padding-sizes #15551
fix: 15327-incorrect-padding-sizes #15551
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
padding-block: 1rem; | ||
padding-block-end: 1.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just combine these in the padding-block
definition 👍🏻
padding-block: 1rem; | |
padding-block-end: 1.5rem; | |
padding-block: 1rem 1.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riddhybansal You can commit the suggestion directly in the "Commit suggestion" or push a new commit to address the changes TJ posted it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
9479afd
Closes #15327
There were inconsistent padding in data tables.
Changelog
Changed
Testing / Reviewing
The guidance from figma designs states that the expandable panel needs 16px padding-top and 24px padding-bottom and this should be consistent in all sizes.