Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15607: Replaced <span> with <div>, Removed unnecessary styling #15610

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Fix #15607: Replaced <span> with <div>, Removed unnecessary styling #15610

merged 5 commits into from
Feb 13, 2024

Conversation

imshubs24
Copy link
Contributor

@imshubs24 imshubs24 commented Jan 26, 2024

Closes #15607

Replaced span with div in that block.

Changelog

Changed

  • Updated HTML structure: Replaced span with div.

Removed

  • Removed unnecessary styling for that div element.

@imshubs24 imshubs24 requested a review from a team as a code owner January 26, 2024 16:32
Copy link
Contributor

github-actions bot commented Jan 26, 2024

DCO Assistant Lite bot All contributors have signed the DCO.

@imshubs24
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@andreancardona
Copy link
Contributor

@slokhande310 Thank you so much for the contribution! Do you mind fixing the failing tests before we review, thanks :)

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 78173ba
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ca860cf30079000807bdd1
😎 Deploy Preview https://deploy-preview-15610--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 13, 2024
Merged via the queue into carbon-design-system:main with commit 56d82b5 Feb 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: violate HTML specification for tiles
4 participants