-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #15607: Replaced <span> with <div>, Removed unnecessary styling #15610
Merged
tay1orjones
merged 5 commits into
carbon-design-system:main
from
imshubs24:bugfix/html-spec-issue
Feb 13, 2024
Merged
Fix #15607: Replaced <span> with <div>, Removed unnecessary styling #15610
tay1orjones
merged 5 commits into
carbon-design-system:main
from
imshubs24:bugfix/html-spec-issue
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
@slokhande310 Thank you so much for the contribution! Do you mind fixing the failing tests before we review, thanks :) |
andreancardona
added
status: waiting for author's response 💬
and removed
status: ready for review 👀
labels
Jan 30, 2024
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Feb 13, 2024
tw15egan
added
status: ready for review 👀
status: one more review 👀
and removed
status: waiting for author's response 💬
labels
Feb 13, 2024
tay1orjones
approved these changes
Feb 13, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Feb 13, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 13, 2024
56d82b5
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15607
Replaced span with div in that block.
Changelog
Changed
Removed