Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AiSkeleton): adds in new AI skeleton states #15711

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 7, 2024

Closes #15622

Adds in three new AI skeleton components, AiSkeletonIcon, AiSkeletonText, and AiSkeletonPlaceholder

Changelog

New

  • AiSkeletonIcon, AiSkeletonText, and AiSkeletonPlaceholder that apply the new AI skeleton styles
  • $ai-skeleton-background and $ai-skeleton-element-background tokens

Testing / Reviewing

Go to Experimental --> unstable__AiSkeleton and ensure the components match the spec

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4750a91
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65c3d26093b3a6000806e7b5
😎 Deploy Preview https://deploy-preview-15711--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 50382a2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ce1e78c20e7d0008a776df
😎 Deploy Preview https://deploy-preview-15711--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan tw15egan added area: AI Used to filter issues in the Carbon for AI project. and removed area: AI Used to filter issues in the Carbon for AI project. labels Feb 7, 2024
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm now it feels a little too slow, could we do like 1250ms?

@tw15egan
Copy link
Member Author

@aagonzales updated 👍🏻

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that looks good! 🎉

@tay1orjones tay1orjones added this pull request to the merge queue Feb 15, 2024
Merged via the queue into carbon-design-system:main with commit 6549549 Feb 15, 2024
21 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.51.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AI enhancements to React Skeleton state enhancements
4 participants