Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): update Modal styles to phase 2 AI spec #15727

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 9, 2024

Closes #15709

Updates Modal to use the new phase 2 AI specs

Changelog

New

  • $ai-overlay token added

Changed

  • Modal styles have been updated to phase 2 spec

Testing / Reviewing

Ensure Modal and ComposedModal under Slug --> Examples matches the spec and there are no regressions

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit cfe54e8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65c63cb498b96b0008bcb055
😎 Deploy Preview https://deploy-preview-15727--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 6385cac
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65cd02046b619c000845e9b0
😎 Deploy Preview https://deploy-preview-15727--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@guidari guidari added this pull request to the merge queue Feb 14, 2024
Merged via the queue into carbon-design-system:main with commit de4793c Feb 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update React Modal to phase 2 AI spec
4 participants