Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NumberInput.tsx to typecast to number during onChange event #15739

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

dkaushik95
Copy link
Contributor

Closes #15735

This change would typecast the value from the input to number similar to when the step function typecasts. This way, the consumers will always receive a value with type number.

Changelog

New

  • {{new thing}}

Changed

  • Return value for onChange for value is a type number

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link
Contributor

github-actions bot commented Feb 12, 2024

DCO Assistant Lite bot All contributors have signed the DCO.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 759c4bb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65cd0fe36b495a0008df3e75
😎 Deploy Preview https://deploy-preview-15739--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dkaushik95
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@tay1orjones tay1orjones added this pull request to the merge queue Feb 14, 2024
Merged via the queue into carbon-design-system:main with commit db6f87a Feb 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NumberInput gives string as a value with an onChange event
3 participants