Refactor/add misc header types #15768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@tay1orjones Would love a review if you all get a chance. |
Merged
via the queue into
carbon-design-system:main
with commit Feb 22, 2024
d19d1f6
20 checks passed
mHuzefa
pushed a commit
to mHuzefa/carbon
that referenced
this pull request
Feb 27, 2024
* refactor: type out Header component * refactor: type out rest of header components * refactor: typed out SideNavLink * refactor: add LinkPropTypes to SideNavLinkProps * refactor: headermenu failing tests, reverting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13585
Closes #13587
Closes #13588
Closes #13604
Renamed and added types for Header, HeaderGlobalAction, HeaderGlobalBar, HeaderMenu, SideNavLink
Changelog
New
Changed
Removed
Testing / Reviewing