-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/add misc header types #15768
Refactor/add misc header types #15768
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tay1orjones Would love a review if you all get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
d19d1f6
* refactor: type out Header component * refactor: type out rest of header components * refactor: typed out SideNavLink * refactor: add LinkPropTypes to SideNavLinkProps * refactor: headermenu failing tests, reverting
Closes #13585
Closes #13587
Closes #13588
Closes #13604
Renamed and added types for Header, HeaderGlobalAction, HeaderGlobalBar, HeaderMenu, SideNavLink
Changelog
New
Changed
Removed
Testing / Reviewing