fix(StaticNotification): set describedby on action button #15856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Fink <[email protected]>
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Not picking up my 2nd commit, so going to recreate this PR.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to a previous PR that added the actionButton capability to StaticNotification. I didn't realize that the aria-describedby was being enforced on the button in addition to the body. My storybook example didn't catch that, b/c the current
useInteractiveChildrenNeedDescriptionis only checking the first interactive child. So when i went to use it with just the button, kaboom.Fully tested it out locally in our microservice, recreating the issue and fixing it.
I also changed the proptype of
subtitleto Node to match actionableNotification, making the swap easier.Changelog
New
aria-describedby. No new prop for this.Changed
subtitleto be PropTypes.Node to match ActionableNotification.Testing / Reviewing
render a StaticNotification within live code with action button and embedded links.