feat(typescript): adds TypeScript types to ChatButto & Skeleton #17297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kennylam
requested changes
Aug 30, 2024
There was a problem hiding this comment.
@2nikhiltom Since the files were moved (renamed), all the history is lost. The way around this is to commit the move (foo.js > foo.ts), then make the Typescript changes in another commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17291
Adds TypeScript types to ChatButto , ChatButto.Skeleton
convers index.js to index.ts
Changelog
New
Added interface
ChatButtonPropsChanged
converted : ChatButton.js ---> ChatButton.tsx
converted : ChatButton.Skeleton.js ---> ChatButton.Skeleton.tsx
converted : index.js ---> index.ts
Testing / Reviewing
Make sure no typescript errors are flagged
Make your existing functionality of component are intact