Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FileUploaderDropContainer): resolve click handler error #17568

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 25, 2024

Closes #17393

This PR updates the FileUploaderDropContainer's click handler to be the expected type of string rather than null

Changelog

Changed

  • evt.target.value type from null to empty string

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3260ed3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66fff8ebaec2e2000897f9e1
😎 Deploy Preview https://deploy-preview-17568--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emyarod emyarod marked this pull request as ready for review September 25, 2024 12:57
@emyarod emyarod requested a review from a team as a code owner September 25, 2024 12:57
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3260ed3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66fff8eb1881ed000807ffe1
😎 Deploy Preview https://deploy-preview-17568--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into carbon-design-system:main with commit 80f0069 Oct 9, 2024
23 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

@emyarod emyarod deleted the 17393-fix/FileUploaderDropContainer-clear-handler-typeerror branch October 10, 2024 16:23
annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting an HTMLInputElement's value to null
4 participants