Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): move feature flag overview under welcome section #17685

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Oct 8, 2024

Closes #17573

We are moving the feature flag overview to sit underneath the welcome section in storybook in order for the feature flag documentation to be more visible

Screenshot 2024-10-08 at 4 21 18 PM

Changelog

Changed

  • change pathing for Feature Flag overview.mdx to be under the "Getting Started" section in storybook

Testing / Reviewing

Check deploy preview and make sure the feature flag overview is visible on the left hand side under "Welcome"

@annawen1 annawen1 requested a review from a team as a code owner October 8, 2024 20:26
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 22b6f50
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6705957afdadb500089f979c
😎 Deploy Preview https://deploy-preview-17685--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 22b6f50
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6705957ac40d890007d3442d
😎 Deploy Preview https://deploy-preview-17685--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (21e4380) to head (22b6f50).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17685      +/-   ##
==========================================
+ Coverage   77.13%   77.20%   +0.06%     
==========================================
  Files         409      409              
  Lines       14024    14024              
  Branches     4355     4327      -28     
==========================================
+ Hits        10818    10827       +9     
+ Misses       3035     3027       -8     
+ Partials      171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tay1orjones tay1orjones added this pull request to the merge queue Oct 9, 2024
Merged via the queue into carbon-design-system:main with commit 6b59491 Oct 9, 2024
36 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants