Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17707 contextmenu type script #17780

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

preetibansalui
Copy link
Contributor

Closes #17707

convert useContextMenu to typeScript

  • {{removed thing}}

Testing / Reviewing

  1. Open Storybook > useContextMenu
  2. it should work as expected.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 691daec
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67188911a2c63a00089211b6
😎 Deploy Preview https://deploy-preview-17780--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 691daec
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671889111195e00008eee716
😎 Deploy Preview https://deploy-preview-17780--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 691daec
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671889115bb07600082ccaf0
😎 Deploy Preview https://deploy-preview-17780--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (b543079) to head (691daec).

Files with missing lines Patch % Lines
...eact/src/components/ContextMenu/useContextMenu.tsx 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17780      +/-   ##
==========================================
+ Coverage   80.16%   80.27%   +0.10%     
==========================================
  Files         406      406              
  Lines       14029    14031       +2     
  Branches     4343     4343              
==========================================
+ Hits        11246    11263      +17     
+ Misses       2617     2604      -13     
+ Partials      166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types: Context menu
2 participants