Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Dropdown): Made the titleText optional in propTypes #17854

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Thamjith
Copy link

Closes #17843

This PR makes the titleText an optional property in the propTypes, since we are only showing titleText conditionally.

Changelog

Changed

  • Made the titleText optional in propTypes.

Testing / Reviewing

  • Remove the titleText property from in "packages/react/src/components/Dropdown/Dropdown.stories.js"
  • Navigate to the packages/react directory using cd packages/react and run yarn storybook
  • Check the console in browsers's developer tools

Copy link
Contributor

github-actions bot commented Oct 23, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@Thamjith
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 1f5c1e2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6719e007f695e800086b3fc8
😎 Deploy Preview https://deploy-preview-17854--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f5c1e2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6719e007e9a0ff0008576c16
😎 Deploy Preview https://deploy-preview-17854--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1f5c1e2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6719e007b390640009d37c48
😎 Deploy Preview https://deploy-preview-17854--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Thamjith
Copy link
Author

recheck

@Thamjith Thamjith marked this pull request as ready for review October 24, 2024 05:46
@Thamjith Thamjith requested a review from a team as a code owner October 24, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown props.titleText is marked as optional in typescript but required in prop-types
1 participant