-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Dropdown): Made the titleText optional in propTypes #17854
base: main
Are you sure you want to change the base?
Fix(Dropdown): Made the titleText optional in propTypes #17854
Conversation
All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
27025c1
to
75ab61b
Compare
recheck |
75ab61b
to
d644eb3
Compare
d644eb3
to
1f5c1e2
Compare
Closes #17843
This PR makes the
titleText
an optional property in the propTypes, since we are only showingtitleText
conditionally.Changelog
Changed
titleText
optional in propTypes.Testing / Reviewing
titleText
property from in "packages/react/src/components/Dropdown/Dropdown.stories.js"cd packages/react
and runyarn storybook