-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control ArrowUp and ArrowDown keys for Dropdown #18324
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18324 +/- ##
==========================================
- Coverage 84.17% 84.17% -0.01%
==========================================
Files 408 408
Lines 14435 14441 +6
Branches 4690 4696 +6
==========================================
+ Hits 12150 12155 +5
- Misses 2121 2122 +1
Partials 164 164 ☔ View full report in Codecov by Sentry. |
Hi @cknabe, trying to follow the ticket linked in the corresponding bug issue - are the rules listed in your PR description coming from another issue?
|
@annawen1 No, #18277 states this:
This PR causes the Dropdown to not open when the user is at the top selection and they press the up arrow key. |
I see, I had understood the issue to mean that the Dropdown should not open at all on |
Closes #18277
Disallows ArrowUp if the first item is selected.
Disallows ArrowDown if the last item is selected.
Allows all key-presses when the Dropdown is open
Allows all key-presses that are not ArrowUp or ArrowDown
Testing / Reviewing