Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Checkbox): react/wc parity #18329

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(Checkbox): react/wc parity #18329

wants to merge 6 commits into from
+53 −2

Conversation

anamikaanu96
Copy link
Contributor

Closes #17927

Checkbox - react and wc parity

Changelog

New

  • packages/web-components/src/components/checkbox/defs.ts

Changed

-packages/web-components/src/components/checkbox/checkbox-group.ts
-packages/web-components/src/components/checkbox/checkbox.scss
-packages/web-components/src/components/checkbox/checkbox.stories.ts

Testing / Reviewing

Added orientation prop and corresponding style.
Tested using storybook , can be checked in storybook controls.

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner January 13, 2025 14:55
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 23821c6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67852965b2b9f30008a67f3e
😎 Deploy Preview https://deploy-preview-18329--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 23821c6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67852966e8aacc0008f73733
😎 Deploy Preview https://deploy-preview-18329--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 23821c6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67852965d6ca6300089115be
😎 Deploy Preview https://deploy-preview-18329--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 27f631e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67889e0ad1d687000832f1ab
😎 Deploy Preview https://deploy-preview-18329--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 27f631e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67889e0a0d0a2400081327e6
😎 Deploy Preview https://deploy-preview-18329--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 27f631e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67889e0a0190590008b968f1
😎 Deploy Preview https://deploy-preview-18329--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (0c2ff15) to head (27f631e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18329   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4660     4690   +30     
=======================================
  Hits        12150    12150           
  Misses       2120     2120           
  Partials      165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anamikaanu96 anamikaanu96 changed the title Checkbox parity fix(Checkbox): react/wc parity Jan 14, 2025
davidmenendez
davidmenendez suggested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one minor nitpick. as a convention we should continue to stick with constants.{ts,js,etc} instead of defs

@tay1orjones tay1orjones requested review from a team and thyhmdo and removed request for a team January 14, 2025 14:26
kennylam
kennylam requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few small changes.

packages/web-components/src/components/checkbox/checkbox-group.ts Outdated Show resolved Hide resolved
packages/web-components/src/components/checkbox/checkbox.scss Outdated Show resolved Hide resolved
packages/web-components/src/components/checkbox/checkbox.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/components/checkbox/checkbox.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/components/checkbox/checkbox.stories.ts Outdated Show resolved Hide resolved
@tay1orjones
Copy link
Member

Hey, thanks for putting up this PR! I just added @thyhmdo as a reviewer to be sure we get a ux and visual review on this.

@anamikaanu96
Copy link
Contributor Author

looks good. one minor nitpick. as a convention we should continue to stick with constants.{ts,js,etc} instead of defs

Hey @davidmenendez Thanks for reviewing! In Carbon Web Components, I’ve noticed that they use the naming convention def.ts for constants.

@anamikaanu96 anamikaanu96 requested a review from kennylam January 16, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmenendez davidmenendez davidmenendez requested changes

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@thyhmdo thyhmdo Awaiting requested review from thyhmdo thyhmdo was automatically assigned from carbon-design-system/design

@kennylam kennylam Awaiting requested review from kennylam

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Checkbox
4 participants
@anamikaanu96 @tay1orjones @kennylam @davidmenendez