-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(badge-indicators): new component #18342
base: main
Are you sure you want to change the base?
feat(badge-indicators): new component #18342
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18342 +/- ##
==========================================
+ Coverage 84.16% 84.18% +0.01%
==========================================
Files 408 409 +1
Lines 14446 14459 +13
Branches 4664 4650 -14
==========================================
+ Hits 12159 12172 +13
- Misses 2122 2123 +1
+ Partials 165 164 -1 ☔ View full report in Codecov by Sentry. |
Today we decided to pivot on the following: Based on the guidance from the open PR, the badge indicator is intended to only be used on a Button/IconButton. That supports:
It feels to me like this should live under |
Another requirement we talked about - the badge indicator should only show on icon-only buttons that have Rather than doing a bunch of conditional types, we'll just mention it in the prop description for /**
* Display a badge on the button. An empty/dot badge if 0, a numbered badge if >0.
* Must be used with size=lg and kind=ghost
*/
badgeCount?: number; We can also provide a dev-only console warning if
|
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}