[FIX] CARDANO_NODE_VERSION environment variable isn't overwritten
#1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Fixes untar of `ccli.tar.gz` ## Where should the reviewer start? Check `scripts/cnode-helper-scripts/guild-deploy.sh:403` ## Motivation and context Solving downloading latest binaries for cardano-cli ## How has this been tested? Manually on my local machine
This reverts commit 4f5618a.
This reverts commit 50e1b64.
|
Fixed in 487935f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
CARDANO_NODE_VERSIONis always overwritten by the fallback value9.1.1.I'm not very good in bash scripting, but as I understand it's that
|| CARDANO_NODE_VERSION=9.1.1will always be set not matter of the value ofCARDANO_NODE_VERSION, but I don't really understand why.I added another fallback check, but I believe it can be a one-liner.
Where should the reviewer start?
Check
scripts/cnode-helper-scripts/guild-deploy.sh:113-114Motivation and context
I want to update to the latest version
9.2.0by addingCARDANO_NODE_VERSIONin the script as environment variableHow has this been tested?
CARDANO_NODE_VERSIONin the script as environment variablefiles/docker/node/release-versions/cardano-node-latest.txtTry to run
./guild-deploy.sh -b ${branch} -s dand check the environment valueCARDANO_NODE_VERSION.