Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MET-1698 retired type #2121

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

Sotatek-TrungHoang
Copy link
Collaborator

@Sotatek-TrungHoang Sotatek-TrungHoang commented Oct 4, 2023

Description

feat: MET-1698 retired type

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: MET-1698

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@sato-thuyetnguyen sato-thuyetnguyen merged commit 4742a73 into develop Oct 10, 2023
2 of 8 checks passed
@sato-thuyetnguyen sato-thuyetnguyen deleted the feature/MET-1698-retired-type branch October 10, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cf-review CF Review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants