Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/met 182 support dark mode #2129

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Feature/met 182 support dark mode #2129

merged 13 commits into from
Oct 6, 2023

Conversation

Sotatek-TruongNguyen4
Copy link
Collaborator

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 commented Oct 5, 2023 •
edited by jira bot
Loading

Description

Support Dark mode

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: MET-182

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 added the cf-review CF Review needed label Oct 5, 2023
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as draft October 6, 2023 02:08
@sato-thuyetnguyen sato-thuyetnguyen marked this pull request as ready for review October 6, 2023 02:29
@sato-thuyetnguyen sato-thuyetnguyen merged commit fee2270 into develop Oct 6, 2023
2 of 6 checks passed
@sato-thuyetnguyen sato-thuyetnguyen deleted the feature/MET-182-support-dark-mode branch October 6, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sato-thuyetnguyen sato-thuyetnguyen sato-thuyetnguyen approved these changes

@Sotatek-TrungHoang Sotatek-TrungHoang Awaiting requested review from Sotatek-TrungHoang

Assignees
No one assigned
Labels
cf-review CF Review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sotatek-TruongNguyen4 @sato-thuyetnguyen