Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MET-1992 update position notice #3040

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Sotatek-TaiTruong
Copy link
Collaborator

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@Sotatek-TaiTruong Sotatek-TaiTruong added hold Hold 1.3.0 For sprint 13 (P3 - sprint 8) and more labels Feb 21, 2024
@Sotatek-TaiTruong Sotatek-TaiTruong marked this pull request as draft February 21, 2024 09:04
@Sotatek-TaiTruong Sotatek-TaiTruong removed the hold Hold label Feb 21, 2024
@Sotatek-TaiTruong Sotatek-TaiTruong marked this pull request as ready for review February 21, 2024 09:12
@Sotatek-TaiTruong Sotatek-TaiTruong merged commit ae890a2 into 0.9.0 Feb 21, 2024
2 of 5 checks passed
@Sotatek-TaiTruong Sotatek-TaiTruong deleted the fix/MET-1992-fix-notice-button-sanchonet branch February 21, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0 For sprint 13 (P3 - sprint 8) and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant