Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stake Address Deregistration #3480

Merged
merged 1 commit into from
May 17, 2024

Conversation

tungnguyendinh
Copy link
Collaborator

@tungnguyendinh tungnguyendinh commented May 17, 2024

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@Sotatek-TaiTruong Sotatek-TaiTruong added the dev-test This label is for sota test purpose label May 17, 2024
@Sotatek-TaiTruong Sotatek-TaiTruong merged commit f6f20da into dev-test May 17, 2024
4 of 5 checks passed
@Sotatek-TaiTruong Sotatek-TaiTruong deleted the bugfix/Stake-Address-Deregistration branch May 20, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-test This label is for sota test purpose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants