Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MET-2390 Remove token icons and show them with nsfw button #4110

Open
wants to merge 2 commits into
base: 1.12.0
Choose a base branch
from

Conversation

tungnguyendinh
Copy link
Collaborator

@tungnguyendinh tungnguyendinh commented Nov 15, 2024

Description

  • Remove token icons and show them with nsfw button

Checklist before requesting a review

Issue ticket number and link

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@tungnguyendinh tungnguyendinh added hold Hold 1.12.0 For sprint 22 (P3 - sprint 17) and more labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.12.0 For sprint 22 (P3 - sprint 17) and more hold Hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant