Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples using cardano-wallet integrations #853

Open
rdlrt opened this issue Nov 8, 2022 · 2 comments
Open

Remove examples using cardano-wallet integrations #853

rdlrt opened this issue Nov 8, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@rdlrt
Copy link
Collaborator

rdlrt commented Nov 8, 2022

I think cardano-wallet is a nice (easy) use-case for individuals running full node and for small-mid custodial services (like exchanges).

But as I keep mentioning on issues/PR-reviews, it's not suitable for service integrations (it would have been relevant perhaps 2 years ago).

On developers.cardano.org itself , we have a few examples that are relevant (still part of above) using cardano-wallet, but users may naively use them thinking of it as a recommended method. We should reduce the coverage and get it replaced with tools that work better for integrations (for example, a mix of cardano-[serialisation|multiplatform]-lib/lucid and ogmios/kupo, scrolls/oura, or dbsync/graphql/koios to interact with chain instead).

@rphair
Copy link
Collaborator

rphair commented Nov 9, 2022

I agree & think this is also an invitation for aspiring developers to build systems vulnerable to hot wallet hacks (if not carefully designed) which are creating bad press recently (high profile example).

@Mercurial
Copy link
Contributor

Mercurial commented Nov 16, 2022

I also agree with this, when we started the developer portal, the mindset was to set the most simplest example possible to convey the basic concepts. I do believe it's time to step it up and that the dev portal endorse a best practice while giving good proof of concept examples at the same time. This was also my sentiment with other sections during the time when the developer portal was newly launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants