Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cf_CardanoWallet builder tool and programming language tag "coldfusion" #894

Closed
wants to merge 3 commits into from

Conversation

fangio10
Copy link
Contributor

  • Title: cf_CardanoWallet
  • Description: An API wrapper of the official Cardano Wallet written in CFML for ColdFusion / Lucee applications, facilitates communication between a ColdFusion server and the Cardano blockchain via the official cardano-wallet
  • Website: https://github.com/fangio10/cf_cardanowallet
  • Getstarted: null
  • Tags: coldfusion, wallet

Added "cf_CardanoWallet" to builder tools
added image asset for cf_cardanowallet tool
fixed image asset reference for cf_cardanowallet
@rdlrt
Copy link
Collaborator

rdlrt commented Dec 20, 2022

Not sure what the aim of this PR is, it's a 2 commit repo against cardano-wallet from over a year ago - makes 0 sense or context to add basic cardano-wallet wrapper to dev portal (also, that cf_ prefix sounds misleading - *ofc, I understand it refers to coldFusion)

@rdlrt rdlrt closed this Dec 20, 2022
@fangio10
Copy link
Contributor Author

really? number of commits and age is irrelevant - it's a tool for cardano and coldfusion developers to facilitate ada payments and other wallet functions on coldfusion based apps.

why would you unilaterally close this without discussion or opinions from others?

@rdlrt
Copy link
Collaborator

rdlrt commented Dec 21, 2022

why would you unilaterally close this without discussion or opinions from others?

Fair enough - have it re-opened now...will let others take the decision 👍🏻

I still dont see a justifiable use-case to use cardano-wallet on integrations, it was fine in 2017-early 2021 perhaps when better integration options werent available (and maybe still alright for individual user/hobbyist use-cases), there is plan to delete the references from dev portal too , #853 ), much less for basic wrappers around it

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reservations raised by @rdlrt are significant. @fangio10 there will come a day when improvised integrations between Cardano & many proprietary platforms will be floating around and we won't be able to preview all of them here: or a least only the most supported & popular ones. I agree the linked repository does look pretty thin from the usual signs of community based maintenance (commits, issues, stars, forks).

Also, since security is a major theme on the Dev Portal documentation & in review criteria, I would not want to "open the can of worms" of endorsing cardano-wallet installation on a closed source web server (therefore having 2 security strikes against this configuration).

@fangio10 fangio10 closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants