Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware Requirements update, drop Marketing #1116

Merged

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jul 29, 2023

1 - I noticed some glaringly out of date specs on the "Minimum hardware requirements" page when I was running through the instructions for some other reason (it wasn't a complete review; this just caught my eye).

2 - We agreed to drop the marketing page but I see it is still in staging and currently on the live site. If people need a review I will go into the many wrong things on this page and all the reasons why I hate it. For now I just want to reference our last consensus to drop the page (circa August 2022)

Following the above agreement to drop it from the outline & the commit history, I don't think we ever followed through to drop it from the branch & so understandably it got merged in with staging along with all the newer stuff. 😅

One nontrivial difference with the last specs is that support for cardano-node on Windows and MacOS is clearly indicated (I don't remember when this appeared... if it were up to me I'd say "Don't try this at home, kids"). With some reluctance I believe that means we should indicate Windows & MacOS as well... but only with as much detail as necessary: experienced SPOs would generally go for Linux but we have to support other points of view including the official one. (I have no idea why they don't include Ubuntu 22.04 since I understand it's in their own testing configuration.)


(link to rewritten page)

@rphair rphair changed the title update node specs, drop marketing page + nav Hardware Requirements update, drop Marketing Jul 29, 2023
@rphair rphair marked this pull request as ready for review July 29, 2023 10:01
Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with overall PR, just added a couple of comments about requirement specifics

docs/operate-a-stake-pool/hardware-requirements.md Outdated Show resolved Hide resolved
docs/operate-a-stake-pool/hardware-requirements.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator Author

rphair commented Jul 29, 2023

Have made some updates. @rdlrt suggestion of using a table might be nice, but I don't think this would work here because it would be a very cramped & asymmetrical table. Link to current version is here (also added to OP): https://github.com/rphair/developer-portal/blob/spo-update-specs-drop-marketing/docs/operate-a-stake-pool/hardware-requirements.md

@rphair rphair requested a review from rdlrt July 30, 2023 08:29
@rphair rphair requested review from gufmar and gitmachtl July 30, 2023 14:56
@katomm katomm merged commit f713a13 into cardano-foundation:staging Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants