broken URL fixes Nov 2024 #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obsolete external domains fix the raw .jsonld file link in the governance action example Bonus: added the announcementBar switch like just implemented on cardano.org
gufmar
commented
Nov 13, 2024
There was a problem hiding this comment.
@gitmachtl or @disassembler
may I ask you to quickly check if this replacement of the URL is ok for the code examples?
Imo it still points to the same jsondld content, and it's just about to fix the link to it.
rphair
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
@gufmar I reviewed it to my own satisfaction yesterday but was waiting for a response to #1353 (comment) ... with no objection yet I believe this is good to merge as-is.
katomm
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: added the
announcementBarswitch in thedocusaurus.config.jsas just implemented on cardano.org