Rust Miner Arch Improvements #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
changed the title
|
It's possible that more logic could be pushed into the |
MitchTurner
commented
Sep 5, 2023
rust-miner/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub async fn run(&self, mut shutdown: oneshot::Receiver<()>) -> Result<()> { |
There was a problem hiding this comment.
Could also have this spawn a task for the loop and return the sender.
|
yea this is great, I'm down to move these changes into |
MitchTurner
changed the title
rvcas
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept thinking about this so I figured I'd write it up and put it out there.
I kept the worker manager as a trait as well because I keep hearing about doing GPU hashing. We could develop a CPU manager for now and then someone could upgrade it to GPU once we figure it out. The abstraction makes that easier.