Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recompute integrity hash #1619

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Do not recompute integrity hash #1619

merged 1 commit into from
Sep 11, 2024

Conversation

ch1bo
Copy link
Collaborator

@ch1bo ch1bo commented Sep 10, 2024

This is not needed anymore as we are not converting between Babbage and Conway transactions anymore. Consequently the TODO comment is also not needed as the upgradeTx / conversion was removed.


  • CHANGELOG update not needed
  • Documentation update not needed
  • Haddocks update not needed
  • No new TODOs introduced; removed one

Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

github-actions bot commented Sep 10, 2024

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-09-11 07:08:54.27513583 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 2fac819a1f4f14e29639d1414220d2a18b6abd6b8e444d88d0dda8ff 3799
νCommit 2043a9f1a685bcf491413a5f139ee42e335157c8c6bc8d9e4018669d 1743
νHead 2ee477c60839936be49a50030690865b5bed4db8cd2f05bf255ac680 10068
μHead a1610f6e64843161f4a88229c0286176f5325de3e2f773eec2b1d818* 4508
νDeposit c2117fd9ebdee3e96b81fd67ff7092d638926415c10f1f7e5a267ad0 2791
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 5094 5.81 2.30 0.44
2 5295 7.27 2.88 0.46
3 5502 8.41 3.32 0.48
5 5901 11.22 4.43 0.53
10 6904 18.02 7.12 0.65
57 16356 82.81 32.75 1.78

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 569 10.52 4.15 0.29
2 757 13.86 5.65 0.34
3 944 17.33 7.20 0.38
5 1319 24.65 10.44 0.48
10 2254 45.22 19.36 0.75
20 4132 95.99 40.76 1.40

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 560 21.46 8.41 0.41
2 114 671 32.13 12.75 0.53
3 170 782 47.29 18.88 0.70
4 226 893 58.99 23.83 0.84
5 285 1004 76.90 31.22 1.04
6 338 1120 90.22 37.01 1.20

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 655 17.70 7.79 0.38
2 732 17.78 8.50 0.39
3 859 19.14 9.76 0.41
5 1253 24.93 13.50 0.50
10 1992 33.20 20.37 0.65
50 7969 98.93 75.05 1.84

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 641 20.11 9.03 0.41
2 787 21.57 10.43 0.43
3 914 22.95 11.79 0.46
5 1285 26.52 15.21 0.53
10 2011 34.24 22.58 0.68
50 8077 97.30 83.26 1.89

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 680 25.93 11.14 0.47
2 845 27.69 12.67 0.50
3 985 29.87 14.49 0.54
5 1316 33.49 17.67 0.61
10 2205 44.04 26.70 0.80
39 6327 98.04 72.69 1.74

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4967 17.43 7.58 0.56
2 5163 29.49 13.01 0.71
3 5234 41.42 18.27 0.85
4 5325 57.21 25.28 1.03
5 5418 66.04 29.11 1.13
6 5658 96.85 43.17 1.49

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4934 7.50 3.17 0.45
5 1 57 4968 8.43 3.80 0.46
5 5 285 5104 13.74 6.98 0.54
5 10 569 5273 19.01 10.37 0.61
5 20 1137 5612 30.72 17.65 0.77
5 30 1707 5954 41.65 24.61 0.93
5 40 2280 6296 52.98 31.73 1.08
5 50 2845 6631 64.59 38.98 1.24
5 81 4608 7681 99.87 61.16 1.74

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2024-09-11 07:09:34.515636257 UTC

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 5.046363390
P99 14.190007419999915ms
P95 6.2741315999999925ms
P50 4.127657ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 24.212268043
P99 116.42679953000004ms
P95 33.04261909999998ms
P50 21.4495965ms
Number of Invalid txs 0

This is not needed anymore as we are not converting between Babbage and
Conway transactions anymore. Consequently the TODO comment is also not
needed as the upgradeTx / conversion was removed.

Signed-off-by: Sasha Bogicevic <[email protected]>
Copy link

Test Results

490 tests  ±0   485 ✅ ±0   20m 38s ⏱️ +32s
155 suites ±0     5 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit 6d2595c. ± Comparison against base commit d4b3cbc.

@v0d1ch v0d1ch merged commit 7025d78 into master Sep 11, 2024
38 checks passed
@v0d1ch v0d1ch deleted the clean-up-coverfee branch September 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants