Skip to content

Commit

Permalink
fix floating deps by limiting @types/qunit update
Browse files Browse the repository at this point in the history
@types/qunit 2.19.11 doesn't work with the ember-qunit setup that this app has. It does apparently work in a clean newly-generated app using ember's native types, instead of all the older `@types/ember__*` packages.

But our test matrix currently includes versions that don't support the nice new native ember types, so I'm just limiting the @types/qunit upgrade for now.
  • Loading branch information
ef4 committed Oct 25, 2024
1 parent 1c325ff commit 1367e3e
Show file tree
Hide file tree
Showing 3 changed files with 1,876 additions and 2,249 deletions.
2 changes: 1 addition & 1 deletion failing-test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@types/ember__template": "^4.0.1",
"@types/ember__test": "^4.0.1",
"@types/ember__utils": "^4.0.2",
"@types/qunit": "^2.19.4",
"@types/qunit": "2.19.10",
"@types/rsvp": "^4.0.4",
"@typescript-eslint/eslint-plugin": "^5.57.1",
"@typescript-eslint/parser": "^5.57.1",
Expand Down
Loading

0 comments on commit 1367e3e

Please sign in to comment.