Allow serialization of full token objects #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In carlos-mg89@f08a062 the AbstractToken::__sleep() method was added, but it breaks serialization of request tokens (as stored in sessions). Bug: samwilson/phpflickr#50
|
@carlos-mg89 I've asked on that commit about why this was added, because it doesn't seem to reference an issue. So this might be the wrong fix! But it works in my testing for PhpFlickr. |
|
Hi @samwilson , I have no idea why that change was done. If you think is not right and you've done some testing about it, and since tests keep passing, I'm more than happy to accept the PR. Will verify in a later occasion and see if there's any issue. |
carlos-mg89
approved these changes
Jul 15, 2022
|
Yeah I couldn't figure it out! But let's see how it goes. :) Thanks for making a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f08a062
the AbstractToken::__sleep() method was added,
but it breaks serialization of request tokens (as stored in sessions).
Bug: samwilson/phpflickr#50