Hardening suggestions for WebGoat_12_23 / pagination #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixee-b1171e79b0e16eb5[bot]](https://avatars.githubusercontent.com/u/14047435?s=60&v=4){kind=small}
| @@ -149,7 +149,9 @@ private Map<String, Object> createAttributes() { | |||
| } | |||
|
|
|||
| private String determineLanguage() { | |||
| int x, y, z; | |||
There was a problem hiding this comment.
Split variable declarations into their own statements.
| @@ -135,7 +136,9 @@ public void print2() { | |||
| public static class EncryptionExample { | |||
|
|
|||
| public byte[] encrypt(String text) throws Exception { | |||
| int a, b, c; | |||
There was a problem hiding this comment.
Split variable declarations into their own statements.
| @@ -79,8 +80,8 @@ public ModelAndView importFile(@RequestParam("file") MultipartFile myFile) throw | |||
| var user = (WebGoatUser) SecurityContextHolder.getContext().getAuthentication().getPrincipal(); | |||
| var destinationDir = new File(fileLocation, user.getUsername()); | |||
| destinationDir.mkdirs(); | |||
| myFile.transferTo(new File(destinationDir, myFile.getOriginalFilename())); | |||
There was a problem hiding this comment.
Wrapped the file name with a sanitizer call that takes out path escaping characters
| @@ -79,8 +80,8 @@ public ModelAndView importFile(@RequestParam("file") MultipartFile myFile) throw | |||
| var user = (WebGoatUser) SecurityContextHolder.getContext().getAuthentication().getPrincipal(); | |||
| var destinationDir = new File(fileLocation, user.getUsername()); | |||
| destinationDir.mkdirs(); | |||
| myFile.transferTo(new File(destinationDir, myFile.getOriginalFilename())); | |||
| log.debug("File saved to {}", new File(destinationDir, myFile.getOriginalFilename())); | |||
There was a problem hiding this comment.
Wrapped the file name with a sanitizer call that takes out path escaping characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (103 - pagination) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs