(CodeQL) Fixed finding: "Prevent information leak of stack trace details to HTTP responses"

[pixee-b1171e79b0e16eb5]

Remediation

This change fixes "Prevent information leak of stack trace details to HTTP responses" (id = stack-trace-exposure) identified by CodeQL.

Details

This change prevents stack trace information from reaching the HTTP response, which could leak code internals to an attacker and aid in further profiling and attacks.

Have you ever seen an error page and thought, "Wow, I certainly shouldn't be seeing all these code details?" That's this problem.

Switching to a safe signature that doesn't leak anything is easy and the changes look something like this:

  try {
    httpResponse.write(output);
  } catch (Exception e) {
-   response.sendError(401, e.getMessage());
+   response.sendError(401);
  }

More reading

• https://codeql.github.com/codeql-query-help/java/java-stack-trace-exposure/
• https://cwe.mitre.org/data/definitions/209.html
• https://cwe.mitre.org/data/definitions/497.html

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: codeql:java/stack-trace-exposure

[carlosu7]

@pixeebot next

[carlosu7]

@pixeebot next

[pixee-b1171e79b0e16eb5]

I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it?

If this change was not helpful, or you have suggestions for improvements, please let me know!

[carlosu7]

@pixeebot next

[carlosu7]

@pixeebot next

[pixee-b1171e79b0e16eb5]

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

[pixee-b1171e79b0e16eb5]

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.

[carlosu7]

@pixeebot next

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[pixee-b1171e79b0e16eb5]

@carlosu7, I opened PR #116, go check it out!

[carlosu7]

@pixeebot next

[pixee-b1171e79b0e16eb5]

@carlosu7, I opened PR #120, go check it out!

[carlosu7]

@pixeebot next

[pixee-b1171e79b0e16eb5]

@carlosu7, I opened PR #123, go check it out!