Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.dm now includes Docker option; fix #167 #169

Closed
wants to merge 1 commit into from

Conversation

joh4nd
Copy link

@joh4nd joh4nd commented Mar 15, 2024

I added to setup.md a short docker setup.

I also numbered the prior instructions such that it was easier to figure out the steps, and to jump to option 2. docker if desired.

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

It should be safe to Approve and Run the workflows that need maintainer approval.

@joh4nd joh4nd marked this pull request as ready for review March 15, 2024 17:14
@joh4nd
Copy link
Author

joh4nd commented Apr 16, 2024

Hi @rbavery, pinging you in case you have not seen this suggestion. Cheers

@rbavery
Copy link
Collaborator

rbavery commented Apr 17, 2024

Thanks @joh4nd for this PR. My initial instinct is to provide just one way to do the setup so that everyone in the workshop can follow the same instructions for starting Jupyter and activating their environment. I do think the Docker instructions could be valuable for advanced users that understand the differences between it and the Conda instructions, but worry that including these would confuse novice users.

Have you found these docker setup instructions particularly more helpful than the Conda instructions in a workshop setting?

@joh4nd
Copy link
Author

joh4nd commented Apr 17, 2024

You choose. I find it easier to run docker than using the Conda instructions, yes. That's why I made it in first place. And when I first did it, I thought I would make it available.

Having that said. Thanks for the geospatial learning materials for python!

ps. a more lightweight image can be used for Jupyter than what I found in first place.

@rbavery
Copy link
Collaborator

rbavery commented Apr 24, 2024

From my past experience teaching these workshops, most learners are grad students or others in academia who aren't familiar with docker. I lean toward not including these instructions in the setup page in order to minimize confusion for them, but I'm happy to refer to these instructions outside of the site. Maybe in a separate readme in this repo and folks who are examining the github looking for a Dockerfile might find it useful.

I'm also curious what other folks think, especially if they have taught this workshop. Would these instructions be helpful in a workshop setting @fnattino @rogerkuou ?

@rogerkuou
Copy link
Contributor

Thanks @joh4nd for the contribution! And thanks @rbavery for the initial review.

I tend to agree with @rbavery that Docker is too advanced for most of our audience.

I have a worry for DOCKER from my side. Based on my teaching experience, most of the workshop audience who have setup problems are organization laptop users who do not have admin rights on their device. I think DOCKER might be a problem here.

On the other hand, a lot of students, especially WINDOWS users, use Anaconda. And the current solution is the least confusing one for them.

@rbavery
Copy link
Collaborator

rbavery commented May 28, 2024

I'm going to close this since I think folks who have taught this are in agreement. Thank you for sharing it though @joh4nd.

@rbavery rbavery closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants