-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update narrative of the course #175
base: main
Are you sure you want to change the base?
Update narrative of the course #175
Conversation
minor updates
… and added references to documentation.
…eospatial-python into issue-90
…eospatial-python into issue-90
…a-access Update usage of raster data
Co-authored-by: Maurice de Kleijn <[email protected]>
…s-ep5 Minor fixes
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Co-authored-by: Maurice de Kleijn <[email protected]>
Add data cube episode
…2024 Updating the material to the new narrative
…pring_2024 minor updates in epi 7, 8 and 10. Also exercise added in epi 8
…on_epi5_intro added intro text about placement epi 5
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/geospatial-python/compare/md-outputs..md-outputs-PR-175 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-10-02 20:58:38 +0000 |
@fnattino All good! I'll go episode by episode and submit reviews for each here. Thanks for the amazing work on this, excited to step through the new episodes. |
|
||
```python | ||
import pystac | ||
items_loaded = pystac.ItemCollection.from_file("../data/stac_json/rhodes_sentinel-2.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer this to point to the file that users downloaded in the preceding cell. since it's a fast cell to run and users who come across this first coding episode online will in all likelihood not be downloading the data beforehand.
Could we call out when users are expected to do that prior to a cell that requires imagery in the data folder instead?
items_loaded = pystac.ItemCollection.from_file("../data/stac_json/rhodes_sentinel-2.json") | |
items_loaded = pystac.ItemCollection.from_file("rhodes_sentinel-2.json") |
We can visualize the calculated NDVI for the AoI at two given dates (before and after the wildfires) by selecting the date: | ||
|
||
```python | ||
ndvi_before = ndvi.sel(time="2023-07-13") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cell that triggers the computation presents a warning
/Users/ryanavery/test-dask-on-ray/.venv/lib/python3.11/site-packages/rasterio/warp.py:387: NotGeoreferencedWarning: Dataset has no geotransform, gcps, or rpcs. The identity matrix will be returned.
dest = _reproject(
we should diagnose why georeferencing is not preserved and try to preserve it in this example so that geospatial metadata can be roundtripped when saving and loading the ndvi raster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though I'm testing this in an env called "dask-on-ray" this is just with vanilla dask and xarray. here are my versions
"odc-stac>=0.3.10",
"pystac>=1.11.0",
"pystac-client>=0.8.3",
"ray>=2.37.0",
"rioxarray>=0.17.0",
"torch>=2.4.1",
"xarray>=2024.9.0",
"leafmap>=0.38.3",
"geopandas>=1.0.1",
As promised during discussions offline, here is the PR that updates the material to include the changes that we have introduced in our fork of the lesson (for reference, that version of the material is deployed here).
More in the specific, this PR introduces the following changes:
@rbavery very sorry for the huge PR, I have tried to split it in smaller chunks by cherry-picking updates on individual episodes. However, various commits seems to have covered multiple files, so it is really not possible to create episode-specific branches at this stage. Of course feel free to submit reviews in parts, if it helps, and please let me/us know if we can do anything else to simplify the review process..
Also cc'ing @Morrizzzzz and @rogerkuou