[#2540] Fix running strategy after update to training progress was made

carpentries · Nov 10, 2023 · 1623ae6 · 1623ae6
1 parent 8ebace9
commit 1623ae6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/amy/trainings/views.py b/amy/trainings/views.py
@@ -106,6 +106,7 @@ class TrainingProgressUpdate(RedirectSupportMixin, OnlyForAdminsMixin, AMYUpdate
     def form_valid(self, form):
         person = form.cleaned_data["trainee"]
         event = form.cleaned_data["event"]
+        result = super().form_valid(form)
         try:
             run_instructor_training_completed_not_badged_strategy(
                 instructor_training_completed_not_badged_strategy(person),
@@ -118,7 +119,7 @@ def form_valid(self, form):
                 self.request,
                 f"Error when creating or updating scheduled email. {exc}",
             )
-        return super().form_valid(form)
+        return result
 
 
 class TrainingProgressDelete(RedirectSupportMixin, OnlyForAdminsMixin, AMYDeleteView):