Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLDT to admin domains #2536

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Sep 20, 2023

fixes #2520.

This will need a dedicated release in the next couple of weeks as we are not close to being ready with v4.3.

@pbanaszkiewicz
Copy link
Contributor

@elichad

This will need a dedicated release in the next couple of weeks as we are not close to being ready with v4.3.

Please create a new release (4.2.1?) and a release branch from release/4.2.0 (or main if we don't have it). Eventually this code will have to be merged into both develop and release/4.2.1.

Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor concerns. Once they're cleared this can be merged.

amy/autoemails/actions.py Show resolved Hide resolved
amy/workshops/models.py Show resolved Hide resolved
@elichad
Copy link
Contributor Author

elichad commented Sep 22, 2023

Created release/v4.2.2 from release/v4.2.1.

@pbanaszkiewicz pbanaszkiewicz self-requested a review September 22, 2023 20:34
@elichad
Copy link
Contributor Author

elichad commented Sep 25, 2023

Thanks @pbanaszkiewicz! I should have time to release this on Wednesday afternoon, so I'll merge it then (unless you want to do the release yourself sooner, which would be fine too)

@elichad elichad merged commit 8b9e582 into develop Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLDT organisation to workshop Administrator options
2 participants