Code

Member codes feature#2575

Code

Merged

elichad merged 103 commits intodevelopcarpentries/amy:developfrom feature/member-codescarpentries/amy:feature/member-codesCopy head branch name to clipboardNov 16, 2023

+2,731-88

Commits

Commits on Sep 18, 2023

• add feature flag for membership codes

  elichad

  committed
  8263dbc

  Copy full SHA for 8263dbc

• set up feature flag correctly

  elichad

  committed
  2bd5475

  Copy full SHA for 2bd5475

• add membership questions to workshop forms

  elichad

  committed
  fd2b71b

  Copy full SHA for fd2b71b

• add "I'm not sure" option and tweak layout

  elichad

  committed
  5f6ae30

  Copy full SHA for 5f6ae30

• create and test code validation, hidden behind feature flag

  elichad

  committed
  ab936ee

  Copy full SHA for ab936ee

• get cleaning working with the feature flag

  elichad

  committed
  5f6f9a7

  Copy full SHA for 5f6f9a7

• add field presence tests

  elichad

  committed
  94d021a

  Copy full SHA for 94d021a

• membership_affiliation -> member_affiliation; membership_code -> member_code

  elichad

  committed
  e301462

  Copy full SHA for e301462

• combine migrations

  elichad

  committed
  b545f8e

  Copy full SHA for b545f8e

• make var name caps as it should be

  elichad

  committed
  b239ac5

  Copy full SHA for b239ac5

• change parent migration

  elichad

  committed
  d917c77

  Copy full SHA for d917c77

Commits on Sep 19, 2023

• clean_membership_info -> validate_member_code

  elichad

  committed
  456e022

  Copy full SHA for 456e022

Commits on Sep 22, 2023

• Merge pull request #2532 from carpentries/feature/add-code-to-workshop-requests

  Show description for 35767e5
  elichad

  authored
  35767e5

  Copy full SHA for 35767e5

• document existing autofill technique

  elichad

  committed
  a21c297

  Copy full SHA for a21c297

• add reference files to design docs

  elichad

  committed
  fc61d90

  Copy full SHA for fc61d90

• add new fields to detail views

  elichad

  committed
  e5377cd

  Copy full SHA for e5377cd

• add member codes to fake workshop requests

  elichad

  committed
  83287c1

  Copy full SHA for 83287c1

• autofill membership when creating events from requests

  elichad

  committed
  5497bd7

  Copy full SHA for 5497bd7

• add tests for autofill

  elichad

  committed
  8f2533e

  Copy full SHA for 8f2533e

Commits on Sep 25, 2023

• fixes to indentation and comments from code review

  elichad

  committed
  da5516b

  Copy full SHA for da5516b

• Merge pull request #2538 from carpentries/feature/autofill-membership-when-accepting-requests

  Show description for b50d63f
  elichad

  authored
  b50d63f

  Copy full SHA for b50d63f

Commits on Oct 13, 2023

• rename group_name -> member_code for consistency

  elichad

  committed
  ec6522e

  Copy full SHA for ec6522e

• add code enforcement to training requests

  elichad

  committed
  2b25d73

  Copy full SHA for 2b25d73

• add tests for member code validation

  elichad

  committed
  b69b09d

  Copy full SHA for b69b09d

• refactor old tests

  elichad

  committed
  9ebfc0a

  Copy full SHA for 9ebfc0a

• add check on active membership

  elichad

  committed
  b40eb61

  Copy full SHA for b40eb61

• add 90-day grace period for registrations

  elichad

  committed
  d1d5536

  Copy full SHA for d1d5536

Commits on Oct 17, 2023

• tweaks from code review

  elichad

  committed
  8a3d8a7

  Copy full SHA for 8a3d8a7

• add active_on_date method for memberships

  elichad

  committed
  73be04b

  Copy full SHA for 73be04b

• use active_on_date in form validation

  elichad

  committed
  658da5d

  Copy full SHA for 658da5d

Commits on Oct 18, 2023

• update form text and error message

  elichad

  committed
  b65b572

  Copy full SHA for b65b572

• Merge pull request #2544 from carpentries/feature/2379-Enforce-membership-code-on-instructor-training-application

  Show description for cad326e
  elichad

  authored
  cad326e

  Copy full SHA for cad326e

Commits on Oct 19, 2023

• add field to override invalid code for soft validation

  elichad

  committed
  00b0c32

  Copy full SHA for 00b0c32

• add tests for soft validation

  elichad

  committed
  fbb5880

  Copy full SHA for fbb5880

• appease the linter

  elichad

  committed
  551184d

  Copy full SHA for 551184d

Commits on Oct 20, 2023

• improvements from code review

  elichad

  committed
  7dafdf9

  Copy full SHA for 7dafdf9

• Merge pull request #2549 from carpentries/feature/2535-Member-codes-Implement-soft-validation-for-member-codes

  Show description for 80389d8
  elichad

  authored
  80389d8

  Copy full SHA for 80389d8

Commits on Oct 23, 2023

• remove member_affiliation field

  elichad

  committed
  b67f751

  Copy full SHA for b67f751

• remove member_affiliation from validate_member_code

  elichad

  committed
  46f87ed

  Copy full SHA for 46f87ed

• remove tests of member_affiliation

  elichad

  committed
  084ba12

  Copy full SHA for 084ba12

• clean up SOW and WI forms/tests

  elichad

  committed
  5f6ddd3

  Copy full SHA for 5f6ddd3

• remove member_affiliation from autofill test

  elichad

  committed
  0073491

  Copy full SHA for 0073491

Commits on Oct 24, 2023

• add seat checks to code validation

  elichad

  committed
  a207676

  Copy full SHA for a207676

• add space

  elichad

  committed
  c551443

  Copy full SHA for c551443

Commits on Oct 25, 2023

• remove rogue space

  elichad

  committed
  e7d55ab

  Copy full SHA for e7d55ab

• number of training seats should be int

  elichad

  committed
  1475715

  Copy full SHA for 1475715

• Merge pull request #2554 from carpentries/feature/extra-validation-for-instructor-training

  Show description for 58a7ee2
  elichad

  authored
  58a7ee2

  Copy full SHA for 58a7ee2

Commits on Oct 26, 2023

• Merge pull request #2552 from carpentries/feature/remove-member-affiliation

  Show description for aef7bad
  elichad

  authored
  aef7bad

  Copy full SHA for aef7bad

Commits on Oct 27, 2023

• update registration code use in fake training requests

  elichad

  committed
  0a4f8cb

  Copy full SHA for 0a4f8cb

• add filter for invalid member codes

  elichad

  committed
  39b7d4a

  Copy full SHA for 39b7d4a

• rename group to member code in label

  elichad

  committed
  2be8829

  Copy full SHA for 2be8829

• change "no_d" filter choice to "pa"

  elichad

  committed
  454133d

  Copy full SHA for 454133d

• add tests for TrainingRequestFilter

  elichad

  committed
  3d3168a

  Copy full SHA for 3d3168a

• add tests for WorkshopRequestFilter

  elichad

  committed
  c3df7f5

  Copy full SHA for c3df7f5

• add filter for members who omitted their code

  elichad

  committed
  caf78b8

  Copy full SHA for caf78b8

• improve filter tests

  elichad

  committed
  5096b94

  Copy full SHA for 5096b94

Commits on Oct 30, 2023

• Merge pull request #2558 from carpentries/feature/2396-Add-filter-to-training-requests-view-for-invalid-code

  Show description for c45fc44
  elichad

  authored
  c45fc44

  Copy full SHA for c45fc44

• Merge pull request #2559 from carpentries/feature/2398-Add-a-filter-to-the-workshop-request-view-to-filter-for-requests-with-invalid-member-codes

  Show description for 12090b9
  elichad

  authored
  12090b9

  Copy full SHA for 12090b9

• Add soft code validation to TR update form

  elichad

  committed
  f8c0fa1

  Copy full SHA for f8c0fa1

• ensure TR char/text fields use default=""

  elichad

  committed
  65bc9bf

  Copy full SHA for 65bc9bf

• add tests for soft validation on update form

  elichad

  committed
  212bbc8

  Copy full SHA for 212bbc8

• update training request autoresponse

  elichad

  committed
  80dac4b

  Copy full SHA for 80dac4b

• add warnings to TR template for invalid member code

  elichad

  committed
  e3927c0

  Copy full SHA for e3927c0

• add registration code to workshop request form

  elichad

  committed
  cbe55cf

  Copy full SHA for cbe55cf

• update TR tests

  elichad

  committed
  c6b98ca

  Copy full SHA for c6b98ca

• add reasons to template warning

  elichad

  committed
  004c519

  Copy full SHA for 004c519

• remove duplicate text

  elichad

  committed
  7aaf7d2

  Copy full SHA for 7aaf7d2

Commits on Nov 6, 2023

• Merge pull request #2561 from carpentries/feature/update-autoresponses

  Show description for 3e522a2
  elichad

  authored
  3e522a2

  Copy full SHA for 3e522a2

• remove reference to uncommitted migrations

  elichad

  committed
  304815b

  Copy full SHA for 304815b

• move member_code_valid to a util function

  elichad

  committed
  1e4fdae

  Copy full SHA for 1e4fdae

• add tests for member_code_valid util function

  elichad

  committed
  65ebc44

  Copy full SHA for 65ebc44

• move training seat checks to a second util function

  elichad

  committed
  7cf6425

  Copy full SHA for 7cf6425

• Merge pull request #2560 from carpentries/feature/2550-Member-codes-Add-soft-validation-of-member-codes-to-TrainingRequestUpdateForm

  Show description for 5784675
  elichad

  authored
  5784675

  Copy full SHA for 5784675

Commits on Nov 7, 2023

• add other code validation criteria

  elichad

  committed
  d3e540e

  Copy full SHA for d3e540e

• add tests for other validation criteria

  elichad

  committed
  e0be675

  Copy full SHA for e0be675

• add test for when enforcement is disabled

  elichad

  committed
  364a923

  Copy full SHA for 364a923

• switch to use util function

  elichad

  committed
  31f577f

  Copy full SHA for 31f577f

• should no longer error if no workshops remaining

  elichad

  committed
  0a934b7

  Copy full SHA for 0a934b7

• add membership workshops remaining to request details

  elichad

  committed
  0d135df

  Copy full SHA for 0d135df

• appease flake8

  elichad

  committed
  f737ae3

  Copy full SHA for f737ae3

• add tests for new function

  elichad

  committed
  7a2d72e

  Copy full SHA for 7a2d72e

• update form initial to use util function

  elichad

  committed
  7a2e8a3

  Copy full SHA for 7a2e8a3

Commits on Nov 8, 2023

• fix WRFInitial tests

  elichad

  committed
  a1b723c

  Copy full SHA for a1b723c

• fix typos

  elichad

  committed
  afb6195

  Copy full SHA for afb6195

• add warning if no match for code

  elichad

  committed
  ff3884c

  Copy full SHA for ff3884c

• move membership info to template tag

  elichad

  committed
  5b423d8

  Copy full SHA for 5b423d8

• add tests for template tag

  elichad

  committed
  8137ced

  Copy full SHA for 8137ced

• fix render error in WRF autoresponder

  elichad

  committed
  f01cdc0

  Copy full SHA for f01cdc0

• remove unused reason for error

  elichad

  committed
  e823281

  Copy full SHA for e823281

• rename file to make more sense

  elichad

  committed
  3c6d624

  Copy full SHA for 3c6d624

• test case where membership is not properly defined

  elichad

  committed
  ee00f7c

  Copy full SHA for ee00f7c

Commits on Nov 10, 2023

• never hide requests with invalid codes

  elichad

  committed
  9f47738

  Copy full SHA for 9f47738

• put member code filters next to each other

  elichad

  committed
  dc8aa2e

  Copy full SHA for dc8aa2e

Commits on Nov 13, 2023

• Merge pull request #2571 from carpentries/feature/fix-member-code-override-filter

  Show description for 2d2f53c
  elichad

  authored
  2d2f53c

  Copy full SHA for 2d2f53c

Commits on Nov 14, 2023

• move description from template tag to template

  elichad

  committed
  39ae00c

  Copy full SHA for 39ae00c

• rename util for better clarity

  elichad

  committed
  a05ba25

  Copy full SHA for a05ba25

• update tests

  elichad

  committed
  9798916

  Copy full SHA for 9798916

Commits on Nov 16, 2023

• Merge pull request #2553 from carpentries/feature/2533-Member-codes-Add-further-checks-for-invalid-code-to-all-workshop-request-forms

  Show description for b962bd5
  elichad

  authored
  b962bd5

  Copy full SHA for b962bd5

• squash migrations

  elichad

  committed
  2c16753

  Copy full SHA for 2c16753

• remove squashed migrations

  elichad

  committed
  889ae2b

  Copy full SHA for 889ae2b

• convert squashed migration to regular; update dependents

  elichad

  committed
  c5c883f

  Copy full SHA for c5c883f

• Merge branch 'develop' into feature/member-codes

  elichad

  committed
  ab37e21

  Copy full SHA for ab37e21

• rebase migrations

  elichad

  committed
  d703472

  Copy full SHA for d703472