Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make agreement_link required field in Membership model #2579

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Nov 23, 2023

Fixes #2307.

@elichad elichad added this to the v4.3 milestone Nov 23, 2023
@elichad elichad self-assigned this Nov 23, 2023
@elichad
Copy link
Contributor Author

elichad commented Nov 23, 2023

Pinging @Talishask @elletjies to give you a heads up that as part of the next release, the "Link to member agreement" field will become required when creating or editing a membership.

Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elichad elichad merged commit b8507fd into develop Nov 27, 2023
11 checks passed
@elichad elichad deleted the feature/2307-Make-Agreement-document-required-field-in-membership-model branch November 27, 2023 12:57
@Talishask
Copy link

Apologies for being late is it possible to undo this?

There are a few types of memberships that do not have a membership agreement document so I am unsure how this will affect those? can we discuss what this will look like?

@elletjies
Copy link
Member

@Talishask in these events can we share the Asana task link or die google drive link?

@Talishask
Copy link

If we do not have consistent information to put in the field then the probably should not be required. If we end up putting random information into the database that will be messy. This will be to you all to decide, my going away recommendation would be to have a reason to do this extra work and be consistent with whatever is decided to go in the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Make "Agreement document" required field in membership model
4 participants