Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline link to CoC #299

Merged
merged 1 commit into from
Oct 4, 2023
Merged

inline link to CoC #299

merged 1 commit into from
Oct 4, 2023

Conversation

tobyhodges
Copy link
Member

When I asked @sstevens2 to de-duplicate the link references in #291, I forgot that this Markdown file needs to be self-contained so that people can find the Code of Conduct from the repository. This PR re-adds the link to the CoC page as an inline link in the file.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-299

The following changes were observed in the rendered markdown documents:

 CODE_OF_CONDUCT.md | 2 +-
 md5sum.txt         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-04 14:36:16 +0000

github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@anenadic
Copy link
Collaborator

anenadic commented Oct 4, 2023

All good now - think we all should be aware of this, which files need to be self-contained and which ones can rely on the links.md to be added by the Workbench magic.

@anenadic anenadic merged commit d82491a into main Oct 4, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
Auto-generated via {sandpaper}
Source  : d82491a
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2023-10-04 15:19:43 +0000
Message : Merge pull request #299 from carpentries/inline-link-coc

inline link to CoC
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
Auto-generated via {sandpaper}
Source  : aabecf7
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-10-04 15:21:03 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d82491a
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2023-10-04 15:19:43 +0000
Message : Merge pull request #299 from carpentries/inline-link-coc

inline link to CoC
@tobyhodges tobyhodges deleted the inline-link-coc branch October 4, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants