Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the analogy of pull requests and editing a shared document #469

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

anenadic
Copy link
Collaborator

@anenadic anenadic commented Dec 4, 2024

Fixes #463.
Will crate a separate issue to create a diagram for a PR collaboration workflow.

Copy link

github-actions bot commented Dec 4, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-469

The following changes were observed in the rendered markdown documents:

 collaborating-team.md | 6 ++++++
 md5sum.txt            | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-04 11:25:53 +0000

github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anenadic, I like this a lot.

Please could you adjust to use sentence line breaks before we merge?

episodes/collaborating-team.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@tobyhodges tobyhodges merged commit 26bab5d into main Dec 4, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Auto-generated via `{sandpaper}`
Source  : 26bab5d
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-12-04 11:26:48 +0000
Message : Merge pull request #469 from carpentries/anenadic-issue463

Add the analogy of pull requests and editing a shared document
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Auto-generated via `{sandpaper}`
Source  : f88bfd8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-04 11:27:36 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 26bab5d
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-12-04 11:26:48 +0000
Message : Merge pull request #469 from carpentries/anenadic-issue463

Add the analogy of pull requests and editing a shared document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve introduction of pull requests
2 participants